Limit OpenFeature fixture submodule updates#11867
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 24e949c | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for the follow up commit!
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
The merge request has been interrupted because the build 8972795207992346701 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status waiting |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Limit OpenFeature fixture submodule updates Remove redundant OpenFeature CODEOWNERS entry Merge branch 'master' into leo.romanovsky/limit-openfeature-submodule-dependabot Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
Motivation
PR #11355 added Dependabot updates for git submodules so the OpenFeature fixture corpus can stay current. Because the rule was scoped to the repository root without an allow-list, Dependabot also started opening JMX Fetch submodule updates, such as #11863. Those updates should remain owned by the existing JMX/APM Java flow, while OpenFeature fixture updates should be labeled and routed to the FFE SDK team.
Changes
This PR restricts the
gitsubmoduleDependabot rule todd-smoke-tests/openfeature/src/test/resources/ffe-system-test-datausing an explicitallowentry.It also applies the expected labels to generated OpenFeature fixture submodule PRs:
comp: openfeaturetag: dependenciestag: no release notesDecisions
I kept
directory: /because Dependabot reads git submodules from the repository.gitmodulesfile. The narrowerallowrule is the guardrail that prevents the same automation from updatingdd-java-agent/agent-jmxfetch/integrations-core.The follow-up request also asked about CODEOWNERS assignment. I checked that path before changing it: the existing
/dd-smoke-tests/openfeature/CODEOWNERS rule already coversdd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data, including the submodule gitlink path that changes in fixture update PRs. Adding an exact duplicate owner line would not change routing, so this PR intentionally leaves CODEOWNERS unchanged.Validation
ruby -e "require 'yaml'; YAML.load_file('.github/dependabot.yml'); puts 'dependabot.yml OK'"git config -f .gitmodules --get-regexp '^submodule\\..*\\.path$'git diff --check